Skip to content

Commit

Permalink
CI: Skip install_solidus check on non-current version
Browse files Browse the repository at this point in the history
The installer always uses the current released minor version
(4.2 time writing this), but the check runs on all pipeline
runs, wasting CI time and precious resources. Also it fails
anyway, because of conflicting dependencies.

So, we only run the check on main and latest minor now.

(cherry picked from commit 8d653a5)
  • Loading branch information
tvdeyen committed Nov 2, 2023
1 parent 594abef commit 79fe082
Showing 1 changed file with 27 additions and 20 deletions.
47 changes: 27 additions & 20 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -249,26 +249,33 @@ jobs:
ruby: "3.0"
steps:
- checkout
- libvips

- install_solidus: { flags: "--sample=false --frontend=starter --authentication=devise" }
- test_page: { expected_text: "The only eCommerce platform you鈥檒l ever need." }
- run:
name: Ensure the correct PayPal is installed for SSF
command: |
cd /tmp/my_app
bundle list | grep 'solidus_paypal_commerce_platform (1.'
- install_solidus: { flags: "--sample=false --frontend=starter --authentication=devise --payment-method=stripe" }
- test_page: { expected_text: "The only eCommerce platform you鈥檒l ever need." }

- install_dummy_app

- install_dummy_app: { extra_gems: "solidus_frontend" }
- run:
name: "Ensure solidus_frontend installer is run"
command: |
test -f /tmp/dummy_extension/spec/dummy/config/initializers/solidus_frontend.rb
- when:
condition:
or:
- equal: [main, << pipeline.git.branch >>]
- equal: [v4.2, << pipeline.git.branch >>]
steps:
- libvips
- install_solidus:
flags: "--sample=false --frontend=starter --authentication=devise"
- test_page:
expected_text: "The only eCommerce platform you鈥檒l ever need."
- run:
name: Ensure the correct PayPal is installed for SSF
command: |
cd /tmp/my_app
bundle list | grep 'solidus_paypal_commerce_platform (1.'
- install_solidus:
flags: "--sample=false --frontend=starter --authentication=devise --payment-method=stripe"
- test_page:
expected_text: "The only eCommerce platform you鈥檒l ever need."
- install_dummy_app
- install_dummy_app:
extra_gems: "solidus_frontend"
- run:
name: "Ensure solidus_frontend installer is run"
command: |
test -f /tmp/dummy_extension/spec/dummy/config/initializers/solidus_frontend.rb
test_solidus:
parameters:
Expand Down

0 comments on commit 79fe082

Please sign in to comment.