Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix meta tags #50

Merged
merged 2 commits into from
Oct 25, 2019
Merged

Fix meta tags #50

merged 2 commits into from
Oct 25, 2019

Conversation

elia
Copy link
Member

@elia elia commented Oct 11, 2019

@elia elia added the bug label Oct 11, 2019
@elia elia self-assigned this Oct 11, 2019
spaghetticode
spaghetticode approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elia
Let meta_title fallback on title within the model
cde71fd
@elia
Set the resource ivar to let meta tags be inferred
2ae7cad 
Solidus sets meta tags if it finds meta_* attributes on the current
controller resource ivar (i.e. names as `controller_name.singularize`).
@elia elia merged commit 7c82901 into master Oct 25, 2019
@elia elia deleted the elia/fix-meta-tags branch October 25, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaghetticode spaghetticode spaghetticode approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees

@elia elia

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meta tag added to pages are added as well as the store ones
3 participants
@elia @spaghetticode @kennyadsl