Update test files

[jtapia]

No description provided.

[aitbw]

Hey @jtapia, thanks a lot for this PR! ❤️ I have some comments I'd like to discuss first before approval:

• Is there any specific reason to support Solidus v1.3 and lower? And even if there's a need for that, I think that change is out of this PR's scope (given its title), what do you think?

• I'm ok with moving the specs under a spree folder, but I don't know if that's what we want given that solidus_auth_devise does not follow this convention; maybe @kennyadsl, @jacobherrington or @tvdeyen can shed some light on this

• I don't know if the new file structure is something we want —for sure the updated Rakefile is needed, but I don't feel the same about the support folder, considering several Solidus extensions are using Solidus Support helpers already, and they include most of the stuff needed to run the specs

Thanks once again, and please, feel free to share your thoughts! ☺️

[tvdeyen]

Thanks. I am fine with the changes. The files were most likely moved to reflect the folder structure of the files under test. Some text editor extensions have plugins that help to switch from test to implementation. For that to work the file structure needs to match.

Also the support folder is a common thing in RSpec. Doesn’t have to do anything with Solidus support IMO.

[jtapia]

Hi @aitbw, thanks for your comments, I considered the original support versions, but if you think that we should only support from 2.X, I can do the change

[kennyadsl]

I'm fine with the changes as well, but I think we should only take into account supported versions (2.4+) and try to use solidus_support helpers as much as possible in extensions.

[kennyadsl]

@jtapia I think you also have to update the travis matrix and remove the v1.3 conditional code

[jtapia]

@kennyadsl done

[kennyadsl]

@jtapia thanks for the PR! I left some comments and I would also ask you to clean commits up a little bit. Maybe some of them could be grouped together?

[jtapia]

@kennyadsl I grouped some commits, let me know if you need any other change

[jtapia]

@kennyadsl I made this change https://github.com/solidusio-contrib/solidus_static_content/pull/28/files#diff-93830fa29d616f7c87903d08b5b1b29aR12 and remove all the extra files that now is provided by solidus_support/extension/feature_helper, what do you think?

[kennyadsl]

Thanks, last question and we are good to go!

[jtapia]

@kennyadsl I tackled the latest comments, let me know what do you think, thanks

[kennyadsl]

Thanks!