Add arm64 platforms for docker image release #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible for you to update the e2e tests to also use these ARM images? Simple extension of what's already there should suffice. |
|
@rjhenry from I understood from the documentation, Github runners do not support ARM64 arch yet. The ARM64 image wouldn't work on the AMD64 ubuntu runner. So, that is a prohibiting factor. What do you suggest then? |
|
Ah, I'd heard rumours that there were ARM64 runners now that Azure has ARM64 machines. I'm happy enough as-is, but I'll get @solidnerd's opinion too - it's his project, after all! |
rjhenry
approved these changes
May 27, 2022
|
This issue has been automatically marked as stale because it has not had any activity for the last 30 days. It will be closed if no further activity occurs during the next 7 days. Thank you for your contributions. |
This was referenced Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces
arm64build in the Dockerfile and release pipeline.Testing: I've self-built and published using buildx and it worked like a charm!