Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facet pivot stats fields overwritten when calling getFacetSet() #1102

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

thomascorthals
Copy link
Member

Fixes #1059.

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9714d3) 97.49% compared to head (3402828) 97.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1102   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         389      390    +1     
  Lines       10141    10147    +6     
=======================================
+ Hits         9887     9893    +6     
  Misses        254      254           
Flag Coverage Δ
unittests 97.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Component/ResponseParser/FacetSet.php 88.62% <100.00%> (+0.20%) ⬆️
...t/ResponseParser/NormalizeParsedJsonStatsTrait.php 100.00% <100.00%> (ø)
src/Component/ResponseParser/Stats.php 100.00% <100.00%> (ø)
src/Component/Result/Stats/Stats.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkalkbrenner mkalkbrenner merged commit b5b434a into solariumphp:master Nov 9, 2023
22 checks passed
@thomascorthals thomascorthals deleted the facet branch November 9, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facet pivot stats fields overwritten when calling getFacetSet()
2 participants