Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change _arrays to _data #61

Merged
merged 4 commits into from
Mar 24, 2023
Merged

change _arrays to _data #61

merged 4 commits into from
Mar 24, 2023

Conversation

Japhiolite
Copy link
Member

see issue #60

@banesullivan
Copy link
Member

banesullivan commented Mar 14, 2023 •
edited
Loading

Looks like there may be a handful of other deprecations from NumPy and Pandas to handle before the tests will pass

@banesullivan
Copy link
Member

Otherwise, the PyVista changes here look good!

@Japhiolite
Copy link
Member Author

Thanks for the feedback Bane!
Yeah, was planning to go forward with this but didn't find time in the last two weeks. Hopefully in the next days :)

@Japhiolite
Copy link
Member Author

Still some tests failing. Two of them I'll be able to fix, but the majority are coming from striplog - agilescientific/striplog#162

@Japhiolite Japhiolite requested a review from Leguark March 23, 2023 15:47
@Japhiolite Japhiolite merged commit 32660f2 into main Mar 24, 2023
@Japhiolite Japhiolite deleted the pr_pyv branch March 24, 2023 10:38
@Japhiolite Japhiolite restored the pr_pyv branch March 27, 2023 10:31
@Japhiolite Japhiolite mentioned this pull request Mar 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leguark Leguark Awaiting requested review from Leguark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Japhiolite @banesullivan