Error handling tutorial #3850
Merged
Error handling tutorial #3850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kciesielski
reviewed
Jun 18, 2024
doc/tutorials/04_errors.md
Outdated
| designated in the HTTP specification as "client errors". | ||
|
|
||
| On the other hand, there are "unexpected errors", that we didn't foresee. When they occur, they signal a bug in | ||
| the server's logic. When this happens, we should respond with a status code between 500 and 599, and log the error |
There was a problem hiding this comment.
suggestion: sometimes we return 503 when there are performance issues of our backend/infrastructure or a dependency, so it's not necessarily caused by a "bug", right?
There was a problem hiding this comment.
ah yes, right. I'll mention this as well, thanks
kciesielski
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.