Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup sourcegraph for scala 3 #369

Open
wants to merge 4 commits into
base: scala3
Choose a base branch
from

Conversation

ghostbuster91
Copy link
Contributor

This PR apart from adding integration with sourcegraph also unifies how java is being set.
The unification part can be revert or done otherwise if desired.

actions/setup-java@v1 supports only one distribution - Zulu OpenJDK (Note that v2 supports wider variety of distributions)
That means PR also changes openjdk distro which is used by the CI pipeline.

While I believe that both changes (unification and switch to Zulu) are beneficial I can agree that they might be split into multiple PRs for better transparency (if needed).

@ghostbuster91 ghostbuster91 changed the title Setup sourcegraph Setup sourcegraph for scala 3 Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant