Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input defaults #20

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Fix input defaults #20

merged 1 commit into from
Nov 2, 2020

Conversation

haines
Copy link
Contributor

@haines haines commented Oct 21, 2020

We noticed turnstyle waiting on runs from a different branch, which was unexpected as we hadn't specified same-branch-only: false.

It turns out that GitHub Actions defaults inputs to empty strings when not specified, so the explicit check for undefined to set the default doesn't work.

Copy link

@ptsavdar ptsavdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

GitHub Actions defaults inputs to empty strings when not specified
@softprops softprops merged commit c4c6d8f into softprops:master Nov 2, 2020
@softprops
Copy link
Owner

Thank you @haines I'll fold this into the next release

@haines haines deleted the fix-input-parsing branch May 20, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants