Skip to content

Commit

Permalink
ci: fix breakpad symbols generation (electron#14981)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexeykuzmin committed Oct 5, 2018
1 parent 5eeff55 commit b45dc78
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
11 changes: 9 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -287,14 +287,17 @@ step-mksnapshot-store: &step-mksnapshot-store
path: src/out/Default/mksnapshot.zip
destination: mksnapshot.zip

step-generate-breakpad_symbols: &step-generate-breakpad_symbols
step-generate-breakpad-symbols: &step-generate-breakpad-symbols
run:
name: Generate breakpad symbols
command: |
cd src
# Build needed dump_syms executable
ninja -C out/Default third_party/breakpad:dump_syms
electron/script/dump-symbols.py -d "$PWD/out/Default/electron.breakpad.syms"
# TODO(alexeykuzmin): Explicitly pass an out folder path to the "zip-symbols.py" script.
export ELECTRON_OUT_DIR=Default
electron/script/zip-symbols.py
step-maybe-native-mksnapshot-gn-gen: &step-maybe-native-mksnapshot-gn-gen
Expand Down Expand Up @@ -415,6 +418,10 @@ steps-electron-build-for-tests: &steps-electron-build-for-tests
# Save all data needed for a further tests run.
- *step-persist-data-for-tests

# Breakpad symbols.
# TODO(alexeykuzmin): We should do it only in nightly builds.
- *step-generate-breakpad-symbols

# Trigger tests on arm hardware if needed
- *step-maybe-trigger-arm-test

Expand All @@ -433,7 +440,7 @@ steps-electron-build-for-publish: &steps-electron-build-for-publish
- *step-electron-build
- *step-electron-dist-build
- *step-electron-dist-store
- *step-generate-breakpad_symbols
- *step-generate-breakpad-symbols

# mksnapshot
- *step-mksnapshot-build
Expand Down
3 changes: 3 additions & 0 deletions vsts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ jobs:
# Build needed dump_syms executable
ninja -C out/Default third_party/breakpad:dump_syms
electron/script/dump-symbols.py -d "$PWD/out/Default/electron.breakpad.syms"
# TODO(alexeykuzmin): Explicitly pass an out folder path to the "zip-symbols.py" script.
export ELECTRON_OUT_DIR=Default
electron/script/zip-symbols.py
displayName: Ninja build app
condition: and(succeeded(), eq(variables['ELECTRON_RELEASE'], '1'))
Expand Down

0 comments on commit b45dc78

Please sign in to comment.