Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of file share mount paths for integration test #998

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

Shruthi-1MN
Copy link
Contributor

What this PR does / why we need it:
Validation of file share mount paths for integration test
If file share already exists then only this file works fine
This test file is to ensure all the mount path exists on your operating system

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
If file share already exists then only this file works fine
This test file is to ensure all the mount path which are created through opensds exists on your operating system
It fails when no file share created from opensds exists on operating system and also when the path doesn't exists on operating system which are created from opensds.

Release note:

df := exec.Command("df")
grep := exec.Command("grep", "-w", "/mnt")
cut := exec.Command("awk", "{print $6}")//, "%", "-f", "1")

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unused code

@Shruthi-1MN Shruthi-1MN force-pushed the fileshare_validation branch 2 times, most recently from df56632 to bfc2962 Compare October 21, 2019 08:47
return s
}

func contains(s []string, e string) bool {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use contains()

@Shruthi-1MN Shruthi-1MN changed the base branch from master to development December 11, 2019 09:16
@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #998 into development will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development     #998   +/-   ##
============================================
  Coverage        34.92%   34.92%           
============================================
  Files               97       97           
  Lines            17563    17563           
============================================
  Hits              6133     6133           
  Misses           10561    10561           
  Partials           869      869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants