permits :description param in new_node_groups

[big32mike]

To add a :description to a NodeGroup upon creation, new_node_group must permit the :description command.

Started POST "/node_groups" for 127.0.0.1 at 2020-06-26 14:38:34 -0700
Processing by NodeGroupsController#create as HTML
  Parameters: {"utf8"=>"✓", "authenticity_token"=>"cpgS7UPu3vVlZR9+2F9R6tKjJdslJGp3xolRnmNPDsZ+smcpy8ANhTmB1oJnPutHjMUQI8AHztgiErNRx7nBTw==", "force_create"=>"false", "node_group"=>{"name"=>"test_description", "description"=>"This doesn't get saved when creating a new group.", "parameter_attributes"=>[{"key"=>"", "value"=>""}], "assigned_node_class_ids"=>[""], "assigned_node_group_ids"=>[""], "assigned_node_ids"=>[""]}}
   (0.1ms)  BEGIN
  ↳ app/controllers/node_groups_controller.rb:19
Unpermitted parameter: :description
Unpermitted parameter: :description
Unpermitted parameter: :description

[sodabrew]

This is great, thank you! If there’s a test for creating a node group by api, please add a description to that test as well.

[sodabrew]

Specifically here:

puppet-dashboard/spec/controllers/node_groups_controller_spec.rb

Lines 13 to 17 in f3e7b34

	describe "#create" do
	it "should create a node group on successful creation" do
	post :create, params: { node_group: { name: 'foo' } }
	assigns[:node_group].name.should == 'foo'
	end

if I could bug you to add a description field in this test and we'll get this merged straight away!

[big32mike]

No problem.

[sodabrew]

Thank you!