Skip to content
This repository has been archived by the owner on Mar 26, 2024. It is now read-only.

Replace progressbar #392

Merged
merged 2 commits into from
Jul 2, 2019
Merged

Replace progressbar #392

merged 2 commits into from
Jul 2, 2019

Conversation

ZeroPointEnergy
Copy link
Collaborator

Some tasks and migrations are causing errors like:

$ bundle exec rake reports:samples:populate
Importing 60 reports from tmp/sample_reports in the background
rake aborted!
NoMethodError: undefined method `now' for ProgressBar::Time:Class
Did you mean?  new

This is because rubocop adds the ruby-progressbar gem which collides with the in-tree implementation we have. Incidently that code snipped we use seems to be a very old version of the ruby-progressbar gem (see their initial commit).

I removed lib/progress_bar.rb from our tree, added the ruby-progressbar gem as a direct dependency and migrated all the tasks and migrations.

@ZeroPointEnergy
replace deprecated IO.lines call with IO.each_line
590b86d
@ZeroPointEnergy
Replace progressbar with ruby-progressbar gem
10dc716 
Rubocop has ruby-progressbar as a dependency and this collided with the
ProgressBar class in lib/progress_bar.rb. This file was actually just a
copy of a very old version of ruby-progressbar (see initial import in
that gem) so the migration is pretty easy.
sodabrew
sodabrew approved these changes Jul 2, 2019
View reviewed changes
Copy link
Owner

@sodabrew sodabrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ZeroPointEnergy ZeroPointEnergy merged commit b8fce86 into sodabrew:master Jul 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sodabrew sodabrew sodabrew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZeroPointEnergy @sodabrew