Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] BroadcastWithAck behavior #4878

Merged
merged 7 commits into from
Jan 2, 2024
Merged

[FIX] BroadcastWithAck behavior #4878

merged 7 commits into from
Jan 2, 2024

Conversation

BCCSTeam
Copy link
Contributor

@BCCSTeam BCCSTeam commented Nov 25, 2023 •
edited
Loading

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behavior

On remote sockets don't call callback with arguments.
Returns null as error and data.

New behavior

On remote sockets with call callback with arguments.
Now it returns error and data from callback.

Other information (e.g. related issues)

@BCCSTeam BCCSTeam changed the title [FIX] [FIX] BroadcastWithAck behavior Nov 25, 2023
@darrachequesne darrachequesne merged commit df8e70f into socketio:main Jan 2, 2024
8 checks passed
@X-oss-byte X-oss-byte mentioned this pull request Jan 26, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Feb 2, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Apr 5, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@WilliamUK17 WilliamUK17 mentioned this pull request May 24, 2024
Open
@dIwnsgml dIwnsgml mentioned this pull request May 24, 2024
Open
@neznaamey neznaamey mentioned this pull request May 24, 2024
Open
@NOUIY NOUIY mentioned this pull request May 24, 2024
Open
@nouhaila49 nouhaila49 mentioned this pull request May 24, 2024
Open
@charley04310 charley04310 mentioned this pull request May 25, 2024
Open
@jhamot jhamot mentioned this pull request May 29, 2024
Open
@seahare-slug seahare-slug mentioned this pull request May 30, 2024
Open
@dIwnsgml dIwnsgml mentioned this pull request May 31, 2024
Open
@charley04310 charley04310 mentioned this pull request May 31, 2024
Open
@NOUIY NOUIY mentioned this pull request Jun 1, 2024
Open
@dIwnsgml dIwnsgml mentioned this pull request Jun 2, 2024
Open
@anand-py anand-py mentioned this pull request Jun 2, 2024
Merged
This was referenced Jun 2, 2024
Open
Open
@dIwnsgml dIwnsgml mentioned this pull request Sep 2, 2024
Open
@thecodefodder thecodefodder mentioned this pull request Sep 3, 2024
Open
This was referenced Sep 4, 2024
Open
Open
@charley04310 charley04310 mentioned this pull request Sep 6, 2024
Open
@WilliamUK17 WilliamUK17 mentioned this pull request Sep 6, 2024
Open
@dIwnsgml dIwnsgml mentioned this pull request Sep 6, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Sep 6, 2024
Open
@karthurian karthurian mentioned this pull request Sep 7, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 7, 2024
Open
@neznaamey neznaamey mentioned this pull request Sep 8, 2024
Open
@strangedreamer4 strangedreamer4 mentioned this pull request Sep 9, 2024
Open
@charley04310 charley04310 mentioned this pull request Sep 10, 2024
Open
@dIwnsgml dIwnsgml mentioned this pull request Sep 10, 2024
Open
@belen1991 belen1991 mentioned this pull request Sep 11, 2024
Open
@charley04310 charley04310 mentioned this pull request Sep 12, 2024
Open
@IT21214134 IT21214134 mentioned this pull request Sep 13, 2024
Open
@WilliamUK17 WilliamUK17 mentioned this pull request Sep 13, 2024
Open
@Erik-EFL Erik-EFL mentioned this pull request Sep 13, 2024
Open
@AKJUS AKJUS mentioned this pull request Sep 13, 2024
Open
@charley04310 charley04310 mentioned this pull request Sep 14, 2024
Open
@X-pose X-pose mentioned this pull request Sep 14, 2024
Open
@IT21214134 IT21214134 mentioned this pull request Sep 14, 2024
Open
@neznaamey neznaamey mentioned this pull request Sep 14, 2024
Open
@dIwnsgml dIwnsgml mentioned this pull request Sep 14, 2024
Open
@karthurian karthurian mentioned this pull request Sep 14, 2024
Open
@WilliamUK17 WilliamUK17 mentioned this pull request Sep 14, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Sep 15, 2024
Open
@charley04310 charley04310 mentioned this pull request Sep 15, 2024
Open
@KOTTAGENVH KOTTAGENVH mentioned this pull request Sep 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrachequesne darrachequesne Awaiting requested review from darrachequesne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BCCSTeam @darrachequesne