Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/socket.io Loading
base: 3.0.0
Choose a base ref
...
head repository: socketio/socket.io Loading
compare: 3.0.1
Choose a head ref
  • 5 commits
  • 23 files changed
  • 2 contributors

Commits on Nov 5, 2020

  1. Configuration menu
    Copy the full SHA
    8a69f15 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2020

  1. fix(typings): update the signature of the emit method

    The previous signature was not compatible with EventEmitter.emit(). The typescript compilation threw:
    
    ```
    node_modules/socket.io/dist/namespace.d.ts(89,5): error TS2416: Property 'emit' in type 'Namespace' is not assignable to the same property in base type 'EventEmitter'.
      Type '(ev: string, ...args: any[]) => Namespace' is not assignable to type '(event: string | symbol, ...args: any[]) => boolean'.
        Type 'Namespace' is not assignable to type 'boolean'.
    node_modules/socket.io/dist/socket.d.ts(84,5): error TS2416: Property 'emit' in type 'Socket' is not assignable to the same property in base type 'EventEmitter'.
      Type '(ev: string, ...args: any[]) => this' is not assignable to type '(event: string | symbol, ...args: any[]) => boolean'.
        Type 'this' is not assignable to type 'boolean'.
          Type 'Socket' is not assignable to type 'boolean'.
    ```
    
    Note: the emit calls cannot be chained anymore:
    
    ```js
    socket.emit("hello").emit("world"); // will not work anymore
    ```
    darrachequesne committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    50671d9 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2020

  1. fix: export ServerOptions and Namespace types (#3684)

    @types/socket.io used to export these.
    AviVahl committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    f62f180 View commit details
    Browse the repository at this point in the history
  2. docs(examples): update examples to Socket.IO v3

    Other examples need some additional work (Redis adapter migration, ...).
    darrachequesne committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    d00c0c0 View commit details
    Browse the repository at this point in the history
  3. chore(release): 3.0.1

    darrachequesne committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    0317a07 View commit details
    Browse the repository at this point in the history
Loading