Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/socket.io-parser
base: 4.2.2
Choose a base ref
...
head repository: socketio/socket.io-parser
compare: 4.2.3
Choose a head ref
  • 4 commits
  • 6 files changed
  • 2 contributors

Commits on Jan 25, 2023

  1. chore: bump ua-parser-js from 1.0.32 to 1.0.33 (#121)

    Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 1.0.32 to 1.0.33.
    - [Release notes](https://github.com/faisalman/ua-parser-js/releases)
    - [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md)
    - [Commits](faisalman/ua-parser-js@1.0.32...1.0.33)
    
    ---
    updated-dependencies:
    - dependency-name: ua-parser-js
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    0841bd5 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. fix: check the format of the event name

    A packet like '2[{"toString":"foo"}]' was decoded as:
    
    {
      type: EVENT,
      data: [ { "toString": "foo" } ]
    }
    
    Which would then throw an error when passed to the EventEmitter class:
    
    > TypeError: Cannot convert object to primitive value
    >    at Socket.emit (node:events:507:25)
    >    at .../node_modules/socket.io/lib/socket.js:531:14
    
    History of the isPayloadValid() method:
    
    - added in [78f9fc2](78f9fc2) (v4.0.1, [email protected])
    - updated in [1c220dd](1c220dd) (v4.0.4, [email protected])
    darrachequesne committed May 22, 2023
    2 Configuration menu
    Copy the full SHA
    3b78117 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dcc70d9 View commit details
    Browse the repository at this point in the history
  3. chore(release): 4.2.3

    darrachequesne committed May 22, 2023
    Configuration menu
    Copy the full SHA
    b6c824f View commit details
    Browse the repository at this point in the history