Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/socket.io-parser
base: 3.3.2
Choose a base ref
...
head repository: socketio/socket.io-parser
compare: 3.3.3
Choose a head ref
  • 2 commits
  • 5 files changed
  • 1 contributor

Commits on Nov 9, 2022

  1. fix: check the format of the index of each attachment 

    A specially crafted packet could be incorrectly decoded.

Example:

```js
const decoder = new Decoder();

decoder.on("decoded", (packet) => {
  console.log(packet.data); // prints [ 'hello', [Function: splice] ]
})

decoder.add('51-["hello",{"_placeholder":true,"num":"splice"}]');
decoder.add(Buffer.from("world"));
```

As usual, please remember not to trust user input.

Backported from b5d0cb7
    @darrachequesne
    darrachequesne committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    fb21e42 View commit details
    Browse the repository at this point in the history

  2. chore(release): 3.3.3 

    Diff: 3.3.2...3.3.3
    @darrachequesne
    darrachequesne committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    cd11e38 View commit details
    Browse the repository at this point in the history