-
Notifications
You must be signed in to change notification settings - Fork 571
Permalink
Loading
Choose a base ref
{{ refName }}
default
Loading
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: socketio/engine.io
base: 6.4.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: socketio/engine.io
compare: 6.4.2
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 7 commits
- 7 files changed
- 3 contributors
Commits on Apr 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for bd6d471 - Browse repository at this point
Copy the full SHA bd6d471View commit details
Commits on May 1, 2023
-
refactor: return HTTP 400 upon invalid request overlap
In both cases, the error comes from the client as it should not send multiple concurrent requests, so a HTTP 4xx code is mandated. Related: #650
Configuration menu - View commit details
-
Copy full SHA for 911d0e3 - Browse repository at this point
Copy the full SHA 911d0e3View commit details -
fix: include error handling for Express middlewares (#674)
Following 24786e7. Reference: https://expressjs.com/en/guide/error-handling.html
1Configuration menu - View commit details
-
Copy full SHA for 9395782 - Browse repository at this point
Copy the full SHA 9395782View commit details -
fix(uws): prevent crash when using with middlewares
The class used to accumulate the response headers did not expose the exact same API as its wrapped type, which could lead to the following error in some rare cases: > TypeError: Cannot read properties of undefined (reading 'end') > at Polling.onDataRequest (build/transports-uws/polling.js:109:53) > at Polling.onRequest (build/transports-uws/polling.js:47:18) > at callback (build/userver.js:94:56) > at uServer.verify (build/server.js:152:9) Related: socketio/socket.io#4643
Configuration menu - View commit details
-
Copy full SHA for 8b22162 - Browse repository at this point
Copy the full SHA 8b22162View commit details -
refactor(types): ensure compatibility with Express middlewares
In order to prevent issues like: > error TS2345: Argument of type 'RequestHandler<ParamsDictionary, any, any, ParsedQs, Record<string, any>>' is not assignable to parameter of type 'Middleware'. > Types of parameters 'req' and 'req' are incompatible. > Type 'IncomingMessage' is missing the following properties from type 'Request<ParamsDictionary, any, any, ParsedQs, Record<string, any>>': get, header, accepts, acceptsCharsets, and 29 more. > > io.engine.use(sessionMiddleware); ~~~~~~~~~~~~~~~~~ Related: socketio/socket.io#4644 We could also have use the RequestHandler type from the @types/express-serve-static-core package, but that would add 5 new dependencies. See also: https://github.com/socketio/engine.io/issues/673
Configuration menu - View commit details
-
Copy full SHA for 0141951 - Browse repository at this point
Copy the full SHA 0141951View commit details -
fix: prevent crash when provided with an invalid query param
A specially crafted request could lead to the following exception: > TypeError: Cannot read properties of undefined (reading 'handlesUpgrades') > at Server.onWebSocket (build/server.js:515:67) This bug was introduced in [1], released in version 5.1.0 and included in version 4.1.0 of the `socket.io` parent package. Older versions are not impacted. [1]: 7096e98
Configuration menu - View commit details
-
Copy full SHA for fc480b4 - Browse repository at this point
Copy the full SHA fc480b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95e2153 - Browse repository at this point
Copy the full SHA 95e2153View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 6.4.1...6.4.2