Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the web app “installable” #148

Merged
merged 2 commits into from
May 18, 2024
Merged

Make the web app “installable” #148

merged 2 commits into from
May 18, 2024

Conversation

julienrf
Copy link
Member

No description provided.

Add a 512×512 icon to make the app installable on Chrome-based browsers

Also tweak the app manifest
Add a 180×180 apple-touch-icon, robots.txt, and inject a service worker.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to use something else if anyone comes up with a better image!

@Boran
Copy link
Contributor

Boran commented May 17, 2024

Icon looks nice and works for chrome/android.

If someone dies not want to install the app (I.e. shortcut), will they be prompted just one I hope, and nit constantly asked?

@julienrf
Copy link
Member Author

will they be prompted just one I hope, and nit constantly asked?

I am not sure. I believe each OS/browser has its own behavior…

@julienrf
Copy link
Member Author

It seems more work is needed to get the installation prompt on Firefox Android but this is a bit complicated to set up so I would like to start with this and improve later.

@julienrf julienrf merged commit 6daad1e into main May 18, 2024
1 check passed
@julienrf julienrf deleted the pwa branch May 18, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants