Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sean Translation test #135

Merged
merged 18 commits into from
Mar 26, 2024
Merged

Sean Translation test #135

merged 18 commits into from
Mar 26, 2024

Conversation

Boran
Copy link
Contributor

@Boran Boran commented Mar 25, 2024

No description provided.

Copy link
Member

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I just have a minor suggestion regarding the french text.

frontend/messages/fr.json Outdated Show resolved Hide resolved
cavalvise and others added 2 commits March 25, 2024 14:44
Traduction IT et corrections FR from Alvise
@Boran
Copy link
Contributor Author

Boran commented Mar 25, 2024

Julien, here is the merge of

  • Italian machine generated textes
  • Corrected by Alvise
  • and 2-3 French corrections

Copy link
Member

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the typos and thank you for the Italian translation!

@@ -68,7 +68,7 @@
"summaryTotalCloudCover": "Couverture nuageuse",
"summaryRainfall": "Précipitations",
"summaryCumuliDepth": "Épaisseur des cumulus",
"summarySoaringLayerDepth": "Couche convective",
"summarySoaringLayerDepth": "Epaisseur couche convective",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message appears in a place where space is expensive:

image

I would recommend keeping “Couche convective” or maybe abbreviating to “Épaisseur couche conv.”

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"summarySoaringLayerDepth": "Epaisseur couche convective",
"summarySoaringLayerDepth": "Épaisseur couche conv.",

Preview:

image

@julienrf julienrf merged commit 48340a6 into soaringmeteo:main Mar 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants