Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSP Always being Enabled unless in debug mode. #9543

Merged

Conversation

misilot
Copy link
Contributor

@misilot misilot commented May 5, 2021

Description

CSP is always enabled unless debug is set to false.
Change: if ((config('app.debug')!='true') || (config('app.enable_csp')=='true')) {
to:
if ((config('app.debug')!='true') && (config('app.enable_csp')=='true')) {

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Have debug = false and enable_csp = false, look for CSP Header in response from server (it will be there)
  • Apply patch
  • Have debug = false and enable_csp = false, look for CSP header in response (it won't be there)

Checklist:

@misilot misilot requested a review from snipe as a code owner May 5, 2021 17:40
@snipe snipe merged commit 4e408cb into snipe:develop May 5, 2021
@misilot misilot deleted the fix-csp-always-enabled-unless-in-debug branch May 5, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants