Fixes an issue that causes Custom Reports to sometimes duplicate items. [ch14587] #9535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rms the CSV to be 'id' so making it a unique value and don't causes repeated items. [ch14587]
|
¡Excellent work, thank you @inietov! :D |
|
(You should never have let me figure out how to do the upside down exclamation point :D :D :D ) |
|
It's a waste of typing if you ask me, I don't use it even when I'm writing in spanish. 😄 |
|
😂
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Custom Reports had a problem that makes some assets to appear duplicated in the CSV that the report generates.
This was caused because the function that appends data to the CSV used the 'chunk' method in case the user had millions of registers. But if the order column we passed to that 'chunk' method is not unique, the database could sometimes get back records that already was appended to the CSV, the column used by the order was
created_atbut if the assets where imported from a file, that date could appear repeated causing this error. This was fixed making the ordering by a really unique column in our assets database:id.Fixes [ch14587]
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test Configuration: