Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #9531 - highlight search box when filled, add clear button #9534

Merged
merged 4 commits into from
May 5, 2021

Conversation

snipe
Copy link
Owner

@snipe snipe commented May 5, 2021

This PR looks noisier than it seems, just because I generated new skins with a new .search-highlight class, in case we wanted to change the colors of the highlight per skin.

Basically it just adds a new searchboxHighlighter() method to the javascript that checks for a value in the search box and highlights it if there is a value, and also adds an X to clear the box. I'd personally prefer an inline X (like we have in the Super Admin Settings search, but Bootstrap Tables kind of doesn't want you to do it that way, they want it as an input group.

ScreenFlow

This fixes #9531

Signed-off-by: snipe <[email protected]>
Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is going to be really nice addition - I can't tell you how many times I'm helping with a customer's instance and I get confused because I forgot I typed something, then I can't see stuff. Happens to me on the AWS console all the time.

Very approved, with very slight whining about the unrelated changes that are inappropriately munged into this PR. Shame shame. But keep signing my paychecks and I'll let it slide :)

@snipe snipe merged commit 57b9b57 into develop May 5, 2021
@snipe snipe deleted the features/9531_highlight_search_box_when_filled branch May 5, 2021 05:00
@snipe
Copy link
Owner Author

snipe commented May 5, 2021

Everyone's a critic ;)

@MWR-Napavine
Copy link

I just noticed that you implemented the feature. Thank you kindly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants