Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile.alpine build error and snipeit runtime permission error #9520

Merged
merged 1 commit into from
May 5, 2021

Conversation

dampfklon
Copy link
Contributor

@dampfklon dampfklon commented May 2, 2021

Description

Executing the docker-compose file leads to an error this pull requests fixes this error by adding the missing \.
After this fix snipeit still does not load because of permission errors, adding -R to chown fixes these errors.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Executing docker-compose file successfully builds and starts snipeit.
After the container started the page is reachable and no errors are repored in the laravel.log

Test Configuration:

  • Docker: 20.10.5
  • Docker-Compose: 1.29.1

Checklist:

@dampfklon dampfklon requested a review from snipe as a code owner May 2, 2021 17:24
@snipe snipe requested a review from uberbrady May 5, 2021 05:29
Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Much appreciated. This definitely looks more correct to me.

@snipe snipe merged commit 37f7768 into snipe:develop May 5, 2021
@dampfklon dampfklon deleted the fix_Alpine_Dockerfile branch May 5, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants