Fixes #9415 Cannot set regex for Custom Field via API. #9443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The validator in the CustomFieldsController reached when a Custom Field is intended to be created via API has a fixed set of formats that ignores custom regexed ones. This change handle those use cases, I think like is a little bit 'clever' and I know how @uberbrady feels about those changes, but I couldn't find another way without change the behaviour of the existing API.
Other fix I though was that if the user needs a Custom Regex format, they probably could add an aditional parameter to the API call
custom_format
or something like that. But let me know what you think, if this works to keep it simpler, if is better to implement the extra parameter, or if you think of another better way. Cheers!Fixes #9415
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: