Change owner while copy #7552
Change owner while copy #7552
Conversation
Copy all files and chown them in a 2nd layer leads to a larger image. See layer 22 and 26 of https://hub.docker.com/layers/snipe/snipe-it/v4.7.8/images/sha256-67c865d91df1b90cef1112f12bbc9c64402dfeafde0bdb160c4f07e785ee0bcc
Dockerfile
Outdated
| @@ -62,8 +62,6 @@ WORKDIR /var/www/html | |||
| # COPY docker/*.php /var/www/html/app/config/production/ | |||
| COPY docker/docker.env /var/www/html/.env | |||
There was a problem hiding this comment.
This seems great! Would we need to also do it here, though? The later chown seems like it would grab this .env file as well?
Let me know about that (or add it, if needed) and I'll get it approved for you right away!
There was a problem hiding this comment.
I'll add a commit to the PR.
There was a problem hiding this comment.
Hi there! Would you still be able to make this change?
If you like, I could refactor the whole Dockerfile, e.g. use multistage build to get rid of all the composer dependencies (git, svn, ...) in the final image. |
|
I think that would be great, after version 5.0 is released - I'd love to shrink that all down, it'll make everyone much happier. |
Cool! After the merge of this PR, I'll look at it. |
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
CRAAAP. I didn't realize this PR was against master instead of develop. :( :( |
|
Hi! Should I change something? |
|
Nah, it's already merged - I just gotta make sure it doesn't get eaten in the develop -> master merge :) |
|
Cool! If I find some time, I'll have a look at the Dockerfiles for some more optimizations. |
* Change owner while copy Copy all files and chown them in a 2nd layer leads to a larger image. See layer 22 and 26 of https://hub.docker.com/layers/snipe/snipe-it/v4.7.8/images/sha256-67c865d91df1b90cef1112f12bbc9c64402dfeafde0bdb160c4f07e785ee0bcc * Copy docker.env as user docker
Copy all files and chown them in a 2nd layer leads to a larger image.
See layer 22 and 26 of https://hub.docker.com/layers/snipe/snipe-it/v4.7.8/images/sha256-67c865d91df1b90cef1112f12bbc9c64402dfeafde0bdb160c4f07e785ee0bcc