Fixing #5470: Checkin emails not working #5838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the routing of the notifications, to only send „checkin“ emails if the „mail on checkin“ flag on the category was set. (and we checkout to a user with a non-empty email)
Notifications to users should be send if the category of the resource (accessory/asset/consumable/license): a) requires the user to confirm acceptance b) should send notifications on checkin/checkout
Adds back a check for the EULA, since the user should receive the EULA if it was set (regardless of other setings on the category, etc)
|
You're on fire!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the routing of checkin notifications, sending them if the category of the checked in item requires:
It also fixes the routing of checkout notifications, sending them if the category of the checked out item requires either
The original issue (#5470) just focuses on the checkin notifications, but the checkout notifications would have shown the same error.