Formalize modals #3898
Merged
Formalize modals #3898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: resources/views/hardware/checkout.blade.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts out the duplicated javascript from the 3 places that were using the modal code -
It's now universally included once, and included in the Mix setup.
(As a side-note, I also removed the gulpfile.js, since having that as well as the webpack file both there at the same time was confusing, and lost me about half an hour or so)
Also, yanked out the password generation code for modal user-creation, and embedded it into the User modal itself. This means that assets/checkout and assets/bulk_checkout now all have access to the same password randomizing javascript code.
In the process, fixed the checkout and bulk-checkout views so that the new refactored modals worked for them as well.