Bugfixes based on functional tests #3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To insert a prefix you had to toggle the checkbox, save the settings and reload. With this script it is immediate. Fixes #1390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed all bugs that made functional tests fail, mostly it was a matter of route names. I marked two tests as incomplete, i'll get back on them later. Added a check based on a suggestion by @dmeltzer
Functional Tests (70)
✔ AccessoriesCest: Ensure that the create accessories form loads without errors (0.64s)
✔ AccessoriesCest: Test validation fails with blank elements (0.61s)
✔ AccessoriesCest: Test validation fails with short name (0.67s)
✔ AccessoriesCest: Test validation succeeds (0.94s)
✔ AccessoriesCest: Ensure i can delete an accessory (0.48s)
✔ AssetModelsCest: Test asset model creation (0.43s)
✔ AssetModelsCest: Test validation fails with blank elements (0.62s)
✔ AssetModelsCest: Test validation succeeds (0.61s)
✔ AssetModelsCest: Ensure i can delete an asset model (0.48s)
✔ AssetsCest: Ensure that the create assets form loads without errors (0.45s)
✔ AssetsCest: Test validation fails with blank elements (0.69s)
✔ AssetsCest: Test validation succeeds (0.68s)
✔ AssetsCest: Ensure i can delete an asset (0.49s)
✔ CategoriesCest: Test category creation (0.47s)
✔ CategoriesCest: Test validation fails with blank elements (0.61s)
✔ CategoriesCest: Test validation succeeds (0.64s)
✔ CategoriesCest: Ensure i can delete a category (0.50s)
✔ CompaniesCest: Test company creation (0.45s)
✔ CompaniesCest: Test validation fails with blank elements (0.62s)
✔ CompaniesCest: Test validation succeeds (0.60s)
✔ ComponentsCest: Ensure that the create components form loads without errors (0.42s)
✔ ComponentsCest: Test validation fails with blank elements (0.61s)
✔ ComponentsCest: Test validation fails with short name (0.64s)
✔ ComponentsCest: Test validation succeeds (0.67s)
✔ ComponentsCest: Ensure i can delete a component (0.48s)
✔ ConsumablesCest: Ensure that the create consumables form loads without errors (0.42s)
✔ ConsumablesCest: Test validation fails with blank elements (0.62s)
✔ ConsumablesCest: Test validation fails with short name (0.63s)
✔ ConsumablesCest: Test validation succeeds (0.68s)
✔ ConsumablesCest: Ensure i can delete a consumable (0.54s)
✔ DepreciationCest: Test depreciation creation (0.41s)
✔ DepreciationCest: Test validation fails with blank elements (0.61s)
✔ DepreciationCest: Test validation fails with short name (0.65s)
✔ DepreciationCest: Test validation succeeds (0.60s)
✔ DepreciationCest: Ensure i can delete a depreciation (0.48s)
✔ GroupsCest: Ensure that the create groups form loads without errors (0.45s)
✔ GroupsCest: Test validation fails with blank elements (0.68s)
✔ GroupsCest: Test validation fails with short name (0.69s)
✔ GroupsCest: Test validation succeeds (0.65s)
[Incomplete] GroupsCest: Ensure I can delete a group (0.29s)
[Incomplete] GroupsCest: Ensure i can edit a group (0.31s)
✔ LicensesCest: Ensure that the create licenses form loads without errors (0.50s)
✔ LicensesCest: Test validation fails with blank elements (0.65s)
✔ LicensesCest: Test validation fails with short name (0.67s)
✔ LicensesCest: Test validation succeeds (0.76s)
✔ LicensesCest: Ensure i can delete a license (0.52s)
✔ LocationsCest: Test location creation (0.47s)
✔ LocationsCest: Test validation fails with blank elements (0.64s)
✔ LocationsCest: Test validation fails with short values (0.62s)
✔ LocationsCest: Test validation succeeds (0.69s)
✔ LocationsCest: Ensure i can delete a location (0.53s)
✔ ManufacturersCest: Test manufacturer creation (0.46s)
✔ ManufacturersCest: Test validation fails with blank elements (0.62s)
✔ ManufacturersCest: Test validation fails with short name (0.68s)
✔ ManufacturersCest: Test validation succeeds (0.63s)
✔ ManufacturersCest: Ensure i can delete a manufacturer (0.59s)
✔ StatusLabelsCest: Ensure that the create statuslabels form loads without errors (0.44s)
✔ StatusLabelsCest: Test validation fails with blank elements (0.64s)
✔ StatusLabelsCest: Test validation succeeds (0.72s)
✔ StatusLabelsCest: Ensure i can delete a status label (0.80s)
✔ SuppliersCest: Ensure that the create settings/suppliers form loads without errors (0.46s)
✔ SuppliersCest: Test validation fails with blank elements (0.68s)
✔ SuppliersCest: Test validation fails with short name (0.67s)
✔ SuppliersCest: Test validation succeeds (1.06s)
✔ SuppliersCest: Ensure i can delete a supplier (0.52s)
✔ UsersCest: Ensure that the create users form loads without errors (0.46s)
✔ UsersCest: Test validation fails with blank elements (0.73s)
✔ UsersCest: Test validation fails with short name (0.73s)
✔ UsersCest: Test validation succeeds (0.75s)
✔ UsersCest: Ensure i can delete a user (0.47s)
Time: 1.66 minutes, Memory: 482.00MB
OK, but incomplete, skipped, or risky tests!
Tests: 70, Assertions: 148, Incomplete: 2.