Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added confirmation popups for deletes #32

Closed
wants to merge 1 commit into from
Closed

Added confirmation popups for deletes #32

wants to merge 1 commit into from

Conversation

chandu
Copy link

@chandu chandu commented Nov 20, 2013

Added confirmation popup for the delete functionality.
Used alertify for the confirmation popups.

Addresses #30

@snipe
Copy link
Owner

snipe commented Nov 20, 2013

This looks good - I'm going to change some of the CSS though, as it doesn't really match the look and feel of the current design.

@snipe
Copy link
Owner

snipe commented Nov 20, 2013

Merged this into the develop branch - thanks for the contribution! Once I tweak the styles, I'll merge it into master. I also fixed a small bug in the default blade, so once I merge this in, you should probably grab a fresh copy.

In the future, please submit pull requests to the develop branch to make my life a little easier. Thanks!

@snipe snipe closed this Nov 20, 2013
@chandu
Copy link
Author

chandu commented Nov 20, 2013

Oh..Sorry, totally forgot about the develop branch for the fix branch and pull request. My bad ...

@snipe
Copy link
Owner

snipe commented Nov 20, 2013

No worries, I appreciate the help :)

@snipe
Copy link
Owner

snipe commented Nov 20, 2013

I actually ended up using a method that uses bootstrap's native modal functionality. It made it easier to inherit the styles, etc and not have to manage styles in separate stylesheets, etc. You can check it out at 34bbf46. Merged everything into master as well.

@chandu chandu deleted the feature-confirm-deletes branch November 26, 2013 02:40
@kwinters1 kwinters1 mentioned this pull request Apr 16, 2015
@cbinstead cbinstead mentioned this pull request Jun 9, 2015
@craig7716 craig7716 mentioned this pull request Jun 12, 2015
@bailantilles bailantilles mentioned this pull request Mar 30, 2016
2 tasks
@zmorrow zmorrow mentioned this pull request May 20, 2016
2 tasks
@ghost ghost mentioned this pull request Jun 9, 2016
2 tasks
@veen1981 veen1981 mentioned this pull request Jul 7, 2016
2 tasks
@cookierun22 cookierun22 mentioned this pull request Jan 28, 2023
2 tasks
@Bjufen Bjufen mentioned this pull request Feb 9, 2023
2 tasks
This was referenced Aug 22, 2023
@jayavman jayavman mentioned this pull request Sep 2, 2023
2 tasks
@manhvt20 manhvt20 mentioned this pull request Mar 18, 2024
2 tasks
@uglycrab uglycrab mentioned this pull request Mar 27, 2024
2 tasks
@jayavman jayavman mentioned this pull request Jul 8, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants