Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #58 #198

Merged
merged 1 commit into from
Jul 22, 2014
Merged

Fixed #58 #198

merged 1 commit into from
Jul 22, 2014

Conversation

buzzedword
Copy link

Added module scoping for all components, and stored lookups in event handlers instead
of querying live. Delays would erroneously cause values to persist.

Additional changes:

  • Javascript on page is now segmented into snipeit.js
  • Added JS global for settings to be injected via Blade
  • Added support for shimming options with test object
  • Broke out document.ready function declarations into discrete components
    • Scoping and cache/live selection lookups fix this bug

@buzzedword
Fixed snipe#58
69fca5d 
Added module scoping for all components, and stored lookups in event handlers instead
of querying live. Delays would erroniously cause values to persist.
snipe added a commit that referenced this pull request Jul 22, 2014
@snipe
Merge pull request #198 from buzzedword/feature/bug-58
a695d85 
Fixed #58
@snipe snipe merged commit a695d85 into snipe:develop Jul 22, 2014
@buzzedword buzzedword deleted the feature/bug-58 branch July 22, 2014 19:08
@tamws27 tamws27 mentioned this pull request May 18, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buzzedword @snipe