Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed importer table background color #14966

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Jun 25, 2024

Description

There was a color discrepancy with the importer while using dark mode themes. background color has been adjusted:
BEFORE:
image

AFTER:
image
image

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Jun 25, 2024

PR Summary

  • New Style for Specific Table Elements
    The team updated the layout files and made changes to the style used for certain table elements, specifically those tagged with 'warning' in our interface. This will improve the visual cues and overall user experience of the software.

Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a little weird but works 😅 👍🏾

@snipe snipe merged commit 4377395 into snipe:develop Jun 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants