Switch to bulk updating to handle audit interval updates #14227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
uberbrady
approved these changes
Feb 6, 2024
| @@ -28,6 +28,7 @@ | |||
| use Illuminate\Support\Str; | |||
| use Illuminate\Support\Facades\Artisan; | |||
| use Illuminate\Support\Facades\Validator; | |||
| use Carbon\Carbon; | |||
There was a problem hiding this comment.
I think you can pull this, but it's no big deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous behavior, when you change the audit interval, it would loop through the assets and update the relative new
next_audit_dateas needed based on the new interval value.This switches to using a mass update and
DB::raw()- which I normally hate doing, but for users with 40k assets, anything else (short of building in a queueing system) simply won't work.I don't love that this doesn't hit the observer, so you won't see these as edits to the asset in the asset history, but if you're editing 10k assets, that might junk up your history report anyway.