Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Select2 functionality in User bulk check-in Delete User #14223

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

Godmartinz
Copy link
Collaborator

Description

This is a weird one...when this page is sized to mobile, the select2 box forgets/fails at being select2. So by adding $("[name='status_id']").select2(); It sort of reminds it (persists it?) that it is a select2 and it functions properly.

MAGIC

Fixes #FD-40290

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@snipe
Copy link
Owner

snipe commented Feb 6, 2024

Thanks for this @Godmartinz - I'm unclear on how select2 forgets that it's select2 only on that field tho?

@snipe
Copy link
Owner

snipe commented Feb 6, 2024

Weirder still, I can reproduce this (only on status label) on my iPhone, but not at my other mobile breakpoints on desktop...

@snipe snipe merged commit 5f8ac66 into snipe:develop Feb 6, 2024
8 checks passed
@snipe
Copy link
Owner

snipe commented Feb 6, 2024

I've merged this for now, but I'd like to figure out why this would fix it in the first place down the line - thank you!

@Godmartinz
Copy link
Collaborator Author

I would like to know whats happening too. I'll do my best to sherlock the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants