-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Google Chat notifications #14191
Conversation
PR Summary
|
@mauro-miatello soon to be! 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't get the Test Google Integration
to pop up. I think the @if
check in the component's blade file on line 128 needs to be updated to remove the $webhook_channel != null
check. I removed it locally to test and was able to get the test notification to work 👍🏾
I made a couple comments but I'm going to come back to do a full review tomorrow.
(loving the additional channels you're implementing)
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more minor thing and this is good to go.
It's not necessary but if you wanted to improve overall readability there is some duplication in the webhook test methods that can be extracted to methods. Again, not holding this up from being merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Good stuff with the notification channels 💪🏾
Description
This adds notifications for check ins and check outs for google chat.
![image](https://private-user-images.githubusercontent.com/47435081/300967129-fabd385d-1ea7-48f7-88af-9a92fa22458a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA5MTI1NjAsIm5iZiI6MTcyMDkxMjI2MCwicGF0aCI6Ii80NzQzNTA4MS8zMDA5NjcxMjktZmFiZDM4NWQtMWVhNy00OGY3LTg4YWYtOWE5MmZhMjI0NThhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEzVDIzMTEwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU0MjA1OTRkMTgxNDM3YjJiN2VhODdkNWU5NGZjYWNlMGViZjhiMTk5MzM5MGEwMGVmNjUzMDRmMmI2ODRiOWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.PLURQo9mh_IFBGXLIq7oSb5p_nSYb4ZpGDKTXrdedUY)
![image](https://private-user-images.githubusercontent.com/47435081/300965145-013b9f80-52e9-4a87-8cae-cf8455639dd8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA5MTI1NjAsIm5iZiI6MTcyMDkxMjI2MCwicGF0aCI6Ii80NzQzNTA4MS8zMDA5NjUxNDUtMDEzYjlmODAtNTJlOS00YTg3LThjYWUtY2Y4NDU1NjM5ZGQ4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEzVDIzMTEwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY5ODFkMDY5YmE0YzM3M2VjMTk4YmU1ZGE0MzNlZWEzNGY4ZWNlYWIzOTkyM2JkMzY5NTE4YzA3YzdmZWJmNjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.VblhlKiRd-XFHhvJ0MS7NmQ87yjK90YLlc3X_WC4lTE)
![image](https://private-user-images.githubusercontent.com/47435081/300965271-2b9fde1b-e3b9-4cf7-9f6f-c62c6e07ba4c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA5MTI1NjAsIm5iZiI6MTcyMDkxMjI2MCwicGF0aCI6Ii80NzQzNTA4MS8zMDA5NjUyNzEtMmI5ZmRlMWItZTNiOS00Y2Y3LTlmNmYtYzYyYzZlMDdiYTRjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEzVDIzMTEwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU5ZjdiOTE2NTU1ODA4ZTRjNTI1MjgxMzM0NTY3ODYzYmRiNmQzMjY2NmFlNzlkNzYyNjQ1OTMzNmIwZWI1MjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.jYosAOLQWzYIZtJwqx8tgbXTRPLVFVZKWQEvzS8BCWQ)
![image](https://private-user-images.githubusercontent.com/47435081/300965322-26c0bc75-6976-4c41-98bc-4a193af99692.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA5MTI1NjAsIm5iZiI6MTcyMDkxMjI2MCwicGF0aCI6Ii80NzQzNTA4MS8zMDA5NjUzMjItMjZjMGJjNzUtNjk3Ni00YzQxLTk4YmMtNGExOTNhZjk5NjkyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEzVDIzMTEwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY1NGQwNjA3N2M3MTZkY2U5ZDgzYjdlZWZlYThkM2Y1Zjc0OTE1MGU0YmM4OGIyMDgxYWZmZTJlZGEyN2FjZDEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.PQMK7OFVx6hv_gA-sEujP5yjUiGJqcs1CxxczSRdlFw)
![image](https://private-user-images.githubusercontent.com/47435081/300965586-6af38465-2e46-47e8-a89b-1b51a4c07709.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA5MTI1NjAsIm5iZiI6MTcyMDkxMjI2MCwicGF0aCI6Ii80NzQzNTA4MS8zMDA5NjU1ODYtNmFmMzg0NjUtMmU0Ni00N2U4LWE4OWItMWI1MWE0YzA3NzA5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEzVDIzMTEwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTlkYTE1ZGViNjU3Yzc2ODYzYzE4Njc5YTExMTFkMWYyOWUxYmEzYTZkMmVlNDNiMTRiYWU5ZTZiY2IyZmE3ZjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.UVT2vHrjkQAtRcZrNnDEs2wLYIE-wGxuxmiBuGnFFSo)
Integrations Settings:
Check in/Out Notifications are clickable and will link you to the user checking out or the asset being checked in.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: