Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #13276 Error Showing Requested Assets #13281

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Jul 10, 2023

Description

I add a withTrashed() method to the function that looks for the relationship between requested assets and the user that request it, so the view doesn't crash when trying to show those assets.

Fixes #13276

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.1
  • MySQL version: 8.0.31
  • Webserver version: PHP Dev server
  • OS version: Debian 10

…quest model, so the view of requestable assets doesn't crash
@what-the-diff
Copy link

what-the-diff bot commented Jul 10, 2023

PR Summary

  • Adapted User Retrieval Mechanism
    The functionality within CheckoutRequest.php document for fetching a user's information, known as requestingUser, has been modified. It now uses the withTrashed method, which ensures it can still find users even if they had been removed from active records before.

  • Conditional User Profile Display
    The requested.blade.php file has been altered to include a condition confirming whether a user's data is available and not hidden from view. If those conditions are met, a link to the user's profile will be visible. This adjustment ensures a smoother, error-free experience when dealing with user's profiles.

@snipe snipe merged commit a5555a1 into snipe:develop Jul 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants