Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added phone, fax to departments, locations, companies #13277

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jul 10, 2023

This just adds the DB columns (sortable and searchable) of phone number and fax on locations, departments, and companies.

@what-the-diff
Copy link

what-the-diff bot commented Jul 10, 2023

PR Summary

  • Extended Data Fields in Index Methods
    Added new fields, specifically 'phone' and 'fax', to the index methods of 'CompaniesController', 'DepartmentsController', and 'LocationsController'. This improvement enables these methods to work with additional information.

  • Amplified Store and Update Methods
    Integrated 'phone' and 'fax' fields to the 'store' and 'update methods of 'CompaniesController' and 'LocationsController' and to the update method of 'DepartmentsController'. This enhancement allows more comprehensive data management.

  • Upgraded Data Transformation
    Enhanced the transformation methods of 'CompaniesTransformer', 'DepartmentsTransformer', and 'LocationsTransformer' by introducing 'phone' and 'fax' fields. This makes data transformation more versatile.

  • Enriched Data Models
    Commenced 'phone' and 'fax' fields within the 'Company', 'Department', and 'Location' models. This enhancement accommodates more detailed data representation.

  • Database Update with New Columns
    Extended 'locations' table in the database with two new columns, one each for 'phone' and 'fax'. This update matches the database structure with the enhanced data models.

  • Improved Edit Blade Views
    Incorporated 'phone' and 'fax' fields in the 'companies.edit', 'departments.edit', and 'locations.edit' blade views. This upgrade enhances the user experience by providing more detailed editing options.

  • Partial Additions and Updates
    Included a new partial 'fax.blade.php' to various edit forms to make the 'fax' field available more broadly, and updated the 'suppliers.edit' blade view to showcase this field. This change widens the deployment of the new field.

Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are a couple copy/paste replacements to be made but otherwise this is great 👍🏾

app/Presenters/CompanyPresenter.php Outdated Show resolved Hide resolved
app/Http/Transformers/CompaniesTransformer.php Outdated Show resolved Hide resolved
app/Http/Transformers/DepartmentsTransformer.php Outdated Show resolved Hide resolved
app/Http/Transformers/LocationsTransformer.php Outdated Show resolved Hide resolved
Signed-off-by: snipe <[email protected]>
@snipe snipe merged commit ba37a9d into develop Jul 11, 2023
4 checks passed
@snipe snipe deleted the features/added_phone_fax_to_locations branch July 11, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants