Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label wrapping on category edit page #13264

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR simply adds a span tag so a label is displayed properly on the category edit page.

Before After
Category edit page before changes Category edit page after changes

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@shortcut-integration
Copy link

@what-the-diff
Copy link

what-the-diff bot commented Jul 6, 2023

PR Summary

  • Improved Readability of Admin/Categories Section
    A formatting adjustment has been made in the admin/categories component. The section for 'Use Default EULA' is now enclosed inside a span tag improving the UI rendering. This change leads to a better user experience and understanding of the platform's elements.

@snipe snipe merged commit 5a9c292 into snipe:develop Jul 6, 2023
4 checks passed
@snipe
Copy link
Owner

snipe commented Jul 6, 2023

How did that even get donked? I specifically did a whole-ass write up about how we have to wrap checkboxes that have links in the text within a span. Sigh.

@marcusmoore marcusmoore deleted the bug/sc-23451 branch July 6, 2023 18:03
@marcusmoore
Copy link
Collaborator Author

Looks like we originally got one but not the other 🙈

whoops

@snipe
Copy link
Owner

snipe commented Jul 7, 2023

Sigh. Thank you for being my second brain. I think we probably need to revisit the quickstart stuff as well. I don’t think I looked at that, since it’s a pain to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants