Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for max PHP version in upgrader #13257

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jul 5, 2023

This just tweaks the upgrade script to check for a version of PHP that's too high. While this is documented in the Requirements section of the docs, this should hopefully provide a safeguard or at least more visual feedback to the upgrading.

If it passes (I had an early exit after the version check just to be able to test - it would normally just continue through the upgrader):

Screenshot 2023-07-05 at 6 46 15 PM

If it fails (I had to use a fake max version number here to trigger the fail):

Screenshot 2023-07-05 at 6 45 59 PM

@what-the-diff
Copy link

what-the-diff bot commented Jul 5, 2023

PR Summary

  • Introduction of Specific Variable Names
    Certain variables including $required_php_min, $php_min_works, and $php_max_wontwork have been introduced or updated in the upgrade.php file to make the code more explicit and maintainable.
  • Improvement of Error Messages
    Errors related to the .env file and PHP version are now communicated more clearly, drastically improving troubleshooting.
  • Inclusion of PHP Version Checks
    The script has been modified to check for the appropriate PHP version range using a function called version_compare, leading to better compatibility assurances.
  • Additional System Information Display
    For debugging purposes, the script now provides additional information to the user, displaying the current PHP version and the path to the php.ini file in the system. This makes it easier to find potential issues related to PHP configurations.

@snipe snipe requested a review from uberbrady July 5, 2023 18:02
@snipe snipe merged commit d37aaee into develop Jul 6, 2023
4 checks passed
@snipe snipe deleted the fixes/check_for_ceiling_in_upgrader branch July 6, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant