Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change settings table saml_idp_metadata to MEDIUMTEXT #13255

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Change settings table saml_idp_metadata to MEDIUMTEXT #13255

merged 1 commit into from
Jul 5, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jul 5, 2023

Fixes #13226

@snipe snipe requested a review from uberbrady July 5, 2023 16:29
@what-the-diff
Copy link

what-the-diff bot commented Jul 5, 2023

PR Summary

  • Enlarged Metadata Storage Capacity
    A new update has been added. Essentially, this change is about expanding the storage space we have for managing certain types of data (specifically SAML Identity Provider Metadata) in our settings. This ensures we don't cut-off or lose important data due to insufficient storage space.

uberbrady
uberbrady approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! Looks solid to me.

@snipe snipe merged commit 35039cd into develop Jul 5, 2023
4 checks passed
@snipe snipe deleted the fixes/larger_field_for_idp_meta branch July 5, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uberbrady uberbrady uberbrady approved these changes

Assignees
No one assigned
Labels
saml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snipe @uberbrady