Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed margin if qr_code present #13233

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Jun 29, 2023

Description

No need to adjust the barcode if a QR code isnt present. thats been accounted for with this.
image

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Jun 29, 2023

PR Summary

  • Adjustment to label visuals
    This update modifies the positioning of the barcode image in labels. The space above the barcode will be adjusted according to certain settings related to QR codes. This could lead to improved readability and usability of the labels.

@snipe
Copy link
Owner

snipe commented Jun 29, 2023

What do we see if there are QR codes?

@snipe snipe merged commit 44b8558 into snipe:develop Jul 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants