Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed barcode and info from overlapping #13232

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

Godmartinz
Copy link
Collaborator

Description This is more of a hotfix for overlapping labels. better solution coming soon.

image

Fixes # FD-36525 #13215

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Jun 29, 2023

PR Summary

  • Adjusted Margin of Barcode Images
    The spacing at the top of barcode images within the hardware resources view has been adjusted. Originally, images were misaligned due to a negative 7-pixel offset from the top. This value has been revised to a negative 14-pixel offset, improving the overall alignment and display of barcode images.

@snipe snipe merged commit bbbeaae into snipe:develop Jun 29, 2023
4 checks passed
@snipe
Copy link
Owner

snipe commented Jun 29, 2023

I know there are a lot of use-cases to try to handle there, but this makes the overlap on the text worse :(

Screenshot 2023-06-29 at 9 24 10 PM

@snipe
Copy link
Owner

snipe commented Jun 29, 2023

If I have QR codes enabled, I still see a bit of overlap, but the text doesn't overlap quite as much.

Screenshot 2023-06-29 at 9 25 38 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants