Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper alias for table scope #13228

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Use proper alias for table scope #13228

merged 1 commit into from
Jun 29, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jun 29, 2023

Saw this pop up on the demo and it seems pretty straightforward. An error would be triggered if you try to sort on model name or number number, since the scope wasn't using the correct aliases.

We could probably clean up the requestable() method in the API controller as well, since we don't actually expose category, etc in that screen.

@what-the-diff
Copy link

what-the-diff bot commented Jun 29, 2023

PR Summary

  • Enhanced Asset Query Method
    The OrderModelNumber method in the Asset model, which is the blueprint for handling asset data in our system, has been updated. This change refines how we fetch specific information, particularly the model_number attribute. With this enhancement, our system can now fetch and order asset data more efficiently.

@snipe snipe merged commit 825e988 into develop Jun 29, 2023
@snipe snipe deleted the bug/sc-23434 branch June 29, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant