Cancel requested assets without checkin/out [ch-17606]

[inietov]

Description

I started working on this looking for a quick and easy win, oh boy! If I was mistaken...

Before we have the Requested Assets view like this:

And now I just added this little button here:

That's basically it, but I have to pass new variables to a route, and change a couple function firms to accept parameters that aren't needed before, I tested it extensively but I would love a couple of extra eyes before merging.

Fixes [ch-17606]

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Test Configuration:

• PHP version: 8.1
• MySQL version: 8.0.31
• Webserver version: PHP dev server
• OS version: Debian 11

[shortcut-integration]

This pull request has been linked to Shortcut Story #17606: Cancel requested asset without checkin/out.

[what-the-diff]

PR Summary

• Enhancement of getRequestItem Method
  The getRequestItem method in the ViewAssetsController.php file is improved with the addition of two new parameters known as cancel_by_admin and requestingUser. These parameters will provide further control and flexibility in the handling of item request.

• Update to the cancelRequest Method
  The cancelRequest method, situated in the Requestable.php file, now accepts a user ID parameter. The code logic has been updated in such a way that it can now cancel requests specifically for the user indicated by the provided ID.

• Addition of Cancel Button in View
  A new button has been added to the hardware/requested.blade.php view file that will allow users to cancel an item request. Concomitantly, a corresponding form and route have also been included to facilitate this process.

• Modification of Route Definition
  The change to the route definition request/{itemType}/{itemId} in the web.php file integrates the new optional parameters cancel_by_admin and requestingUser. This inclusion represents an extension to the originally defined pathway, lending more nuanced access and control to your admin operations.

[marcusmoore]

Nice! I have a couple minor requests / suggestions but the functionality works.

---

I noticed the table lost search and sorting somehow:

---

Side-note: Something that comes to mind is an Adam Wathan presentation called "Cruddy by Design" (I'm pretty sure it's this presentation where he talks about this concept). This controller method seems like it can be broken up into dedicated methods for each operation it handles. It would be easier to understand and more maintainable. It doesn't have to happen in this PR of course. Just something that came to mind.

[snipe]

One small change, since we don't use that orange color anywhere else in the UI

[inietov]

Ok, made the button change and add the translation string for the tooltip. Also I was struggling with that Form:: open/close functions... and ultimately got rid of it, because it was too hard to debug.

No, in reality I think it was a copy paste from other time, because it was for the Bulk edit feature, which is not used in this view, that's the real reason.

[marcusmoore]

Looks good to me 👍🏾

[brianhoganm]

Description

I started working on this looking for a quick and easy win, oh boy! If I was mistaken...

Before we have the Requested Assets view like this:

And now I just added this little button here:

That's basically it, but I have to pass new variables to a route, and change a couple function firms to accept parameters that aren't needed before, I tested it extensively but I would love a couple of extra eyes before merging.

Fixes [ch-17606]

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Test Configuration:

• PHP version: 8.1
• MySQL version: 8.0.31
• Webserver version: PHP dev server
• OS version: Debian 11

Hi, I updated my SnipeIT to the latest version with this update. However, when I click on Requested I now get a 500 Server Error. I think this update might have broke this. Can anyone else confirm this? Thanks.