Improve testing around company scoping #13211
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR mainly provides tests around scoping by company in order to support future changes to scoping functionality.
The test with the most interest is
Tests\Unit\CompanyScopingTest
since it checks to make sure the following models are directly scoped by company when Full Multiple Companies Support is enabled:Accessory
Asset
Component
Consumable
License
In addition to the following related models:
AssetMaintenance
through theAsset
modelLicenseSeat
through theLicense
modelThe actual code changes in this PR are focused in controllers and simply remove
Company::scopeCompanyables
where it is not needed because the models mentioned above use either theCompanyableTrait
orCompanyableChildTrait
which applies a query scope when the model is booted.