Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current value added to asset index page #13197

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

akemidx
Copy link
Collaborator

@akemidx akemidx commented Jun 22, 2023

Current value has been added as a column in the assets index page.

Screenshot 2023-06-22 at 5 02 34 PM

FIxes: FD-36095

Additionally, translations have been added in the Warranty and Depreciation column headers when exporting reports.

Cocurrently, I discovered that Current Value is not sorting correctly, tho looking like it should. This is occuring in multiple places, and is a fix that is out of scope for this PR. Therefore, CV will NOT correctly sort high to low or low to high at this time.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

tested locally

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Jun 22, 2023

PR Summary

  • Modified conditions for adding headers in ReportsController.php
    The conditions for adding headers in the "ReportsController" were updated, removing "Warranty" and "Depreciation" headers, and adding new headers for "book_value" and "warranty".

  • Added key-value pair to AssetsTransformer.php output
    A new key-value pair was added to the transformation output in "AssetsTransformer", with the "book_value" key storing the linear depreciated value of the asset.

  • New column definition added to AssetPresenter.php
    A new column definition was added to the "dataTableLayout()" method in "AssetPresenter", with the field name "book_value" and the title "book_value".

@snipe
Copy link
Owner

snipe commented Jul 19, 2023

Looks great, ty! We’re going to need to address the search/sort thing down the line, but this is a great start!

@snipe snipe merged commit a19a508 into snipe:develop Jul 19, 2023
3 of 4 checks passed
@akemidx akemidx deleted the current_value_for_assets branch April 23, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants