Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Serial Number the logic checked against for new imports #13169

Merged
merged 4 commits into from
Jul 6, 2023

Conversation

akemidx
Copy link
Collaborator

@akemidx akemidx commented Jun 14, 2023

Change to importing licenses.

When importing new licenses and the "update existing" is unchecked, the serial number will now be the unique identifier used for imports.

For licenses that have multiple seats on one serial number, users should enter the amount of seats in a column titled seats to match the importer syntax. Users can then assign seats out view the view page, or by clicking into the specific license and clicking on the seats tab.

NOTE: clicking the update existing will overwrite data if multiple matching serial numbers are in the import file. Thus, users are advised to be sure of their data before importing with update existing checked.

Fixes #
Freshdesk: 35948, 35412, et al
Github: #8947

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
-Tested locally with sample imports of all combos of names/serial numbers

Test Configuration:

  • PHP version: 8.0
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Jun 14, 2023

PR Summary

  • Improved License Importer
    The license importer now finds matching licenses using the serial number rather than the name, for better accuracy.
  • Default Reassignable Setting
    If the reassignable attribute is not set, it will now default to '1' (true), allowing easier license management.

Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, and it's pretty impressive how few lines you were able to get it done in! I asked for one small change which should get us the "best of both worlds" - the old way, and the new way. If you can take a stab at making that fix and getting it tested (definitely check blank serials), then I'll feel pretty confident about getting it merged.

app/Importer/LicenseImporter.php Outdated Show resolved Hide resolved
@snipe snipe merged commit 2faa73f into snipe:develop Jul 6, 2023
@akemidx akemidx deleted the license_sn_check1 branch April 23, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants