Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #13098: Status Label Chart Color, resets to default when editing a Status Label #13098

Merged

Conversation

ak-piracha
Copy link
Contributor

Description

This PR includes a fix for the issue tracked under issue number #13049. The issue involved the Status Label Chart Color resetting to its default state when a Status Label was being edited. This was problematic as it didn't allow users to maintain their chosen colour when making modifications to their Status Labels.

Fixes #13049

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A: Create a new Status Label, set a custom colour, save and edit the same Status Label. Verified that the custom colour remained.
  • Test B: Edit an existing Status Label with a custom colour. Verified that the custom colour remained during the editing process.

Test Configuration:

  • PHP version: 8.0
  • MySQL version: 8.1.17
  • Webserver version: Apache/2.4.56 (Debian)
  • OS version: Mac OS

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented May 29, 2023

PR Summary

  • Color Picker Initialization Improved
    The color picker now uses the variable $color for initialization, providing more flexibility than relying on a hardcoded value.

  • Default Color Selection Improved
    The default color selection will now use an existing old input if available, otherwise, it will fall back to the item's current color attribute, enhancing the user experience.

@ak-piracha ak-piracha changed the title Fixed Fixed: Status Label Chart Color, resets to default when editing a Status Label May 29, 2023
@ak-piracha ak-piracha changed the title Fixed: Status Label Chart Color, resets to default when editing a Status Label Fixed #13098: Status Label Chart Color, resets to default when editing a Status Label May 29, 2023
Copy link
Owner

@snipe snipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small stylistic change - thanks!

resources/views/statuslabels/edit.blade.php Outdated Show resolved Hide resolved
resources/views/statuslabels/edit.blade.php Outdated Show resolved Hide resolved
@ak-piracha ak-piracha requested a review from snipe June 1, 2023 05:55
@ak-piracha
Copy link
Contributor Author

ak-piracha commented Jun 14, 2023

@snipe: The requested change has been implemented.

@snipe snipe merged commit 0049920 into snipe:develop Jun 15, 2023
3 checks passed
@snipe
Copy link
Owner

snipe commented Jun 15, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants