Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal Import Users - Update fields only #5408

Closed
2 tasks done
smksar opened this issue Apr 21, 2018 · 3 comments
Closed
2 tasks done

Universal Import Users - Update fields only #5408

smksar opened this issue Apr 21, 2018 · 3 comments
Labels
❓ not sure if bug This issue has not been confirmed as a bug yet

Comments

@smksar
Copy link

smksar commented Apr 21, 2018

Hi, this is my very first ever post on GitHub. Loving Snipe-It much! Thank you for your all your kind efforts, it is truly appreciated~~!!!

Attempting to replace current self developed Excel macros for tracking our IT assets.

Expected Behavior (or desired behavior if a feature request)

Love the universal import, but was hoping when I reimport the same user CSV file I used before but this time with updated fields it will:

  1. Replace fields with current input to empty. Say extension 1234 to blank
  2. Does not at all touch the user's current password

P/S: Clicked the checkbox to "Update Existing Values?"

Actual Behavior

What I experienced was that:

  1. I noticed if a field has value like extension 1234, it will not then make it blank if in the import file value is empty.
  2. It totally did something with the user's password as when I try to login again with the confirmed correct password, it says invalid =(.

Please confirm you have done the following before posting your bug report:


Provide answers to these questions:

  • Is this a fresh install or an upgrade?
    Totally fresh
  • Version of Snipe-IT you're running
    4.2.0
  • Version of PHP you're running
    WAMP 7.1.16
  • Version of MySQL/MariaDB you're running
    WAMP 5.7.21
  • What OS and web server you're running Snipe-IT on
    Windows 10
  • What method you used to install Snipe-IT (install.sh, manual installation, docker, etc)
    install.sh GitHub
  • WITH DEBUG TURNED ON, if you're getting an error in your browser, include that error
  • What specific Snipe-IT page you're on, and what specific element you're interacting with to trigger the error
  • If a stacktrace is provided in the error, include that too.
  • Any errors that appear in your browser's error console.
  • Confirm whether the error is reproducible on the demo: https://snipeitapp.com/demo.
  • Include any additional information you can find in storage/logs and your webserver's logs.
  • Include what you've done so far in the installation, and if you got any error messages along the way.
  • Indicate whether or not you've manually edited any data directly in the database

Please do not post an issue without answering the related questions above. If you have opened a different issue and already answered these questions, answer them again, once for every ticket. It will be next to impossible for us to help you.

https://snipe-it.readme.io/docs/getting-help

@snipe
Copy link
Owner

snipe commented Jun 8, 2018

@dmeltzer can you take a look at this when you get a moment?

@snipe snipe added the ❓ not sure if bug This issue has not been confirmed as a bug yet label Jun 8, 2018
@dmeltzer
Copy link
Contributor

The first issue is deliberate. The idea is that if you have updates, you can provide a csv with only those columns and data that is not provided will not be touched. I could look into adding an option for working in either way, but the code already has a lot of conditionals and different behavior in different situations and I feel like adding another branch is only going to cause more issues. The second issue does not sound like it's working as intended.. I'll look into it.

dmeltzer added a commit to dmeltzer/snipe-it that referenced this issue Jun 16, 2018
The temporary password cannot be added to the users data until after do
any update-related logic, otherwise their password will be overwritten.
@snipe snipe closed this as completed in 2d18b73 Jun 21, 2018
@smksar
Copy link
Author

smksar commented Jul 2, 2018

@dmeltzer thank you for fixing the #2 issue which is not to do anything with password when updating.

I understand the reason behind way of handling for issue #1, but is it possible to put a checkbox "Replace Current Field Values with Blanks?:" under current "Update Existing Values?:" checkbox?

Nevertheless, thank you so much again for fixing issue #1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❓ not sure if bug This issue has not been confirmed as a bug yet
Projects
None yet
Development

No branches or pull requests

3 participants