Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset report fatal exception #2499

Closed
1 task done
stephenspence86 opened this issue Aug 26, 2016 · 4 comments
Closed
1 task done

Asset report fatal exception #2499

stephenspence86 opened this issue Aug 26, 2016 · 4 comments
Labels
✋ bug Confirmed bug
Milestone

Comments

@stephenspence86
Copy link

Expected Behavior (or desired behavior if a feature request)

When I attempt to download a CSV asset report I should get an asset report downloaded, as in the demo,


Actual Behavior

The system throws the following error:

FatalErrorException in ReportsController.php line 170:
Call to undefined method App\Helpers\Helper::parsePurchasedCost()
in ReportsController.php line 170

Initally when trying to reproduce in the demo I wondered if it was becuase purchase cost was blank, so I have gone in an changed the assets to £0 cost, but it throws the same error.

The local is set to EN-GB and the currency is set to £ (with this sign)


Please confirm you have done the following before posting your bug report:


Please provide answers to these questions before posting your bug report:

  • Version of Snipe-IT you're running: v3.3.0-16-ge52a0f6
  • What OS and web server you're running Snipe-IT on: Ubuntu 15.04 & Apache 2.4
  • What method you used to install Snipe-IT: Manual installation
  • Confirm whether the error is reproduceable on the demo: No
  • Include any additional information you can find in app/storage/logs and your webserver's logs.
  • Include what you've done so far in the installation, and if you got any error messages along the way. I had some trouble getting my server configured correctly, but no problems since then
  • Indicate whether or not you've manually edited any data directly in the database no
@dmeltzer
Copy link
Contributor

That is indeed a bug. I renamed the method but must have missed this occurance in reportcontroller...

dmeltzer added a commit to dmeltzer/snipe-it that referenced this issue Aug 26, 2016
Missed this instance when renaming the method. Sorry!
@stephenspence86
Copy link
Author

Great, thanks! If I run git pull will I get this fix?

@dmeltzer
Copy link
Contributor

Not yet, it will need to be merged by snipe first. You can just edit Line 170 of reportscontroller to say Helper::formatCurrencyOutput instead of Helper::parsePurchaseCost temporarily, and then overwrite it when pulling later.

@stephenspence86
Copy link
Author

Fantastic, That works a treat. Thanks for the great support!

@snipe snipe closed this as completed in 9bf3403 Aug 26, 2016
@snipe snipe added this to the v3.4.0 milestone Aug 31, 2016
@snipe snipe added the ✋ bug Confirmed bug label Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✋ bug Confirmed bug
Projects
None yet
Development

No branches or pull requests

3 participants